Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preset tests #1

Merged
merged 4 commits into from
Jul 25, 2024
Merged

Add preset tests #1

merged 4 commits into from
Jul 25, 2024

Conversation

hwmarkcheng
Copy link
Collaborator

Checklist

Adding Preset Integration and unit tests for the Preset ingestion method.

Test setup:

Copy link
Collaborator Author

@hwmarkcheng hwmarkcheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#TODO still need to add mock request for test_response = self.session.get(f"{self.config.connect_uri}/version")

@@ -108,7 +108,7 @@ class SupersetConfig(
api_key: Optional[str] = Field(default=None, description="Preset.io API key.")
api_secret: Optional[str] = Field(default=None, description="Preset.io API secret.")
manager_uri: str = Field(
default="https://api.app.preset.io/", description="Preset.io API URL"
Copy link
Owner

@llance llance Jul 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I need to do some refactoring. I don't think api_key, api_secret and manager_uri should belong to SupersetConfig class since it is only relevant to PresetConfig. Ill put up a separate PR to remove those fields from SupersetConfig and you can rebase against master after it gets merged.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think the only preset portion this is used might be the authentication endpoint?
Preset API is split to preset specific/superset:

https://api-docs.preset.io/#cdf2f4d7-1842-4a3e-bd15-a747295704ee

@hwmarkcheng hwmarkcheng marked this pull request as ready for review July 25, 2024 14:38
@hwmarkcheng hwmarkcheng merged commit 4e03a23 into master Jul 25, 2024
@hwmarkcheng hwmarkcheng deleted the add-preset-tests branch July 25, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants