Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for the neighbor_idx attribute of topologies #171

Merged
merged 1 commit into from
Jul 18, 2018
Merged

Add test for the neighbor_idx attribute of topologies #171

merged 1 commit into from
Jul 18, 2018

Conversation

whzup
Copy link
Collaborator

@whzup whzup commented Jul 17, 2018

Added a new test to the topology classes for the neighbor_idx attribute, checks if it is assigned. Changed the way the neighbor_idx attribute is assigned in the Star and Pyramid topology

Added a new test to the topology classes for the neighbor_idx attribute, checks if it is assigned. Changed the way the neighbor_idx attribute is assigned in the Star and Pyramid topology
@whzup whzup requested a review from ljvmiranda921 July 17, 2018 18:39
Copy link
Owner

@ljvmiranda921 ljvmiranda921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything LGTM! Will merge in a while

@ljvmiranda921 ljvmiranda921 merged commit b90c973 into ljvmiranda921:development Jul 18, 2018
@whzup whzup deleted the neighbor_idx branch July 19, 2018 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants