[New] support enumerable Symbol properties #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Dec 20, 2023
Americas
force-pushed
the
main
branch
2 times, most recently
from
059f5fc to
5e5b9e8
Compare
ljharb
reviewed
Dec 20, 2023
ljharb
approved these changes
Dec 20, 2023
ljharb
changed the title
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if traverse encounters an object with a Symbol property, it does not see it so it skips and anything nested under it.
This PR adds two small changes (one is even a TODO comment) to allow traverse to walk into those properties and further iterate down its chain.