passing circular ref update forEach test but failing for likewise wit…

…h map
ljharb · Feb 18, 2011 · d411695 · d411695
1 parent 42b6b84
commit d411695
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 5 deletions.
diff --git a/index.js b/index.js
@@ -83,7 +83,7 @@ function walk (root, cb) {
     var path = [];
     var parents = [];
 
-    return (function walker (node) {
+    (function walker (node) {
         var modifiers = {};
 
         var state = {

diff --git a/test/circular.js b/test/circular.js
@@ -55,16 +55,26 @@ exports.doubleCirc = function () {
     assert.eql(circs.length, 2);
 };
 
-exports.circDubUp = function () {
+exports.circDubUpForEach = function () {
     var obj = { x : [ 1, 2, 3 ], y : [ 4, 5 ] };
     obj.y[2] = obj;
     obj.x.push(obj.y);
 
-    var c = Traverse(obj).map(function (x) {
+    Traverse(obj).forEach(function (x) {
         if (this.circular) this.update('...');
     });
 
-    console.dir(c);
+    assert.eql(obj, { x : [ 1, 2, 3, [ 4, 5, '...' ] ], y : [ 4, 5, '...' ] });
+};
+
+exports.circDubUpMap = function () {
+    var obj = { x : [ 1, 2, 3 ], y : [ 4, 5 ] };
+    obj.y[2] = obj;
+    obj.x.push(obj.y);
+
+    var c = Traverse(obj).map(function (x) {
+        if (this.circular) this.update('...');
+    });
 
-    assert.eql(c, { x : [ 1, 2, 3, '...' ], y : [ 4, 5, '...' ] });
+    assert.eql(c, { x : [ 1, 2, 3, [ 4, 5, '...' ] ], y : [ 4, 5, '...' ] });
 };