[New] catch errors from runQuery
#50
Conversation
Green-Ranger11
force-pushed
the
handle-error
branch
from
8f28c55
to
3a6fa74
Compare
| }, | ||
| }); | ||
| } catch (err) { | ||
| throw err.message; |
There was a problem hiding this comment.
this line might need some work to cover the token being included in the output (#51). want to do that in this PR, or in a followup?
There was a problem hiding this comment.
But I will work on the rate limit issues in another PR
There was a problem hiding this comment.
Follow up question was #51 run on this branch? Currently the only output should be the message and I'm recreating graphql errors and no tokens are being displayed in this PR
There was a problem hiding this comment.
I think the message contained the token, because it contained the request that was rate-limited.
There was a problem hiding this comment.
In case of a GraphQL error, error.message is set to a combined message describing all errors returned by the endpoint. All errors can be accessed at error.errors. error.request has the request options such as query, variables and headers set for easier debugging.
So I would expect the rate limit to return just the message but anyhow I'll try and rate limit myself to test it out.
There was a problem hiding this comment.
ohhhhh so maybe it was dumping the error.request contents. you're probably right! but good to verify.
There was a problem hiding this comment.
Yep its the following:
If there's anything else should we land this and i get started asap on the other action items for the rate limits.
This closes #33