fix: signal handling for Concourse 7.5 #164
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be a change (unidentified as yet) in Concourse 7.5 that
results in no longer being able to stop or time-out once Terraform is
running. This change introduces a wrapper around the Terraform command
that catches signals and kills the Terraform process group if one is
detected.
Resolves #163
Notes:
fmt.Printf()
for logging,logger.Logger
should be used instead. But I found that in order to passlogger.Logger
then I would have to make a lot of changes in a lot of layers. I'm happy making this change if that's preferred.client.terraformCmd()
into the newrunner
package to create a "tfrunner" package, but it looked like it would be a bigger change and wasn't clearly a better implementation.