Skip to content

Commit

Permalink
Temporary update chromedriver for CI windows tests after node upgrade (
Browse files Browse the repository at this point in the history
  • Loading branch information
liza-mae authored Dec 5, 2018
1 parent 4c09d26 commit 75c2c9f
Showing 1 changed file with 20 additions and 0 deletions.
20 changes: 20 additions & 0 deletions ci/kibana/jenkins_kibana_tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -393,13 +393,33 @@ function install_yarn() {
function yarn_kbn_bootstrap() {
echo_info "Installing node.js dependencies"
#yarn config set cache-folder "$Glb_Cache_Dir/yarn"

# Temporary to get windows tests to run in CI until chromedriver is officially bumped
# See: https://github.com/elastic/kibana/pull/24925
# TODO: Remove later
local _node_ver=$(cat .node-version)
if [ "$_node_ver" == "8.14.0" ]; then
sed -ie 's/"chromedriver": "2.42.1"/"chromedriver": "2.44"/g' package.json
fi

yarn kbn bootstrap
}

# ----------------------------------------------------------------------------
function check_git_changes() {

local _git_changes="$(git ls-files --modified)"
if [ "$_git_changes" ]; then

# Temporary to get windows tests to run in CI until chromedriver is officially bumped
# See: https://github.com/elastic/kibana/pull/24925
# TODO: Remove later
if [ "$_git_changes" == "package.json" ] && [ "$_node_ver" == "8.14.0" ]; then
echo_warning "\nTemporary package.json modified for chromedriver."
git diff package.json
return
fi

echo_error_exit "\n'yarn kbn bootstrap' caused changes to the following files:\n$_git_changes"
fi
}
Expand Down

0 comments on commit 75c2c9f

Please sign in to comment.