Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BattleGrounds: Refactor and Fix bots re-spawning when graveyard meanwhile gets lost #937

Merged
merged 11 commits into from
Feb 4, 2025

Conversation

nl-saw
Copy link
Collaborator

@nl-saw nl-saw commented Feb 2, 2025

This resolves an issue where bots could fail to revive if a graveyard was captured by the opposing faction while they were awaiting respawn.

Changes:

  • Faction Check: Added validation to ensure the Spirit Service is friendly.
  • Search Range: Broadened the Spirit Service search radius beyond the default visibility distance to be reliable in dynamic scenarios.
  • Refactored so things are a bit more structured and clear.

@nl-saw nl-saw closed this Feb 2, 2025
@nl-saw nl-saw reopened this Feb 2, 2025
* Refactored ReleaseSpiritAction.cpp

* Ref ReleaseSpiritAction.h
@nl-saw nl-saw changed the title BattleGrounds: Fix bots re-spawning when graveyard meanwhile gets lost BattleGrounds: Refactor and Fix bots re-spawning when graveyard meanwhile gets lost Feb 2, 2025
@hermensbas hermensbas merged commit 308c0b4 into liyunfan1223:master Feb 4, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants