Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the need to set CARGO_MAKE_TOOLCHAIN as an environment variable for cargo-make builds #185

Closed
simlay opened this issue Oct 4, 2024 · 0 comments · Fixed by #191
Closed

Remove the need to set CARGO_MAKE_TOOLCHAIN as an environment variable for cargo-make builds #185

simlay opened this issue Oct 4, 2024 · 0 comments · Fixed by #191
Labels
good first issue Good for newcomers

Comments

@simlay
Copy link
Contributor

simlay commented Oct 4, 2024

Right now to do local builds using cargo-make you must do:
CARGO_MAKE_TOOLCHAIN=nightly-aarch64-apple-darwin cargo make uniffi-swift-test

Ideally, this should just be cargo make uniffi-swift-test

Something is incorrect with the CARGO_MAKE_TOOLCHAIN and the CARGO_MAKE_TOOLCHAIN_DEFAULT.

Note that this environment variable is used in CI.
@simlay simlay added the good first issue Good for newcomers label Oct 4, 2024
mobile-bungalow added a commit to mobile-bungalow/liveview-native-core that referenced this issue Oct 14, 2024
@mobile-bungalow
Merge branch 'main' of https://github.com/liveview-native/liveview-na…
7079e33 
…tive-core into liveview-native#185
@mobile-bungalow mobile-bungalow mentioned this issue Oct 14, 2024
Merged
simlay pushed a commit that referenced this issue Oct 14, 2024
@mobile-bungalow
Resolve #185: Remove redundant environment variable (#191)
b4b3ef2 
* remove redundant variable, update gitignore

* rerun ci local to fork
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
LiveViewNative Core
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolve #185: Remove redundant environment variable mobile-bungalow/liveview-native-core
1 participant
@simlay