This repository has been archived by the owner on Aug 9, 2022. It is now read-only.
Fix production build #265
Merged
Fix production build #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 2, 2018 12:12
The production build failing was the result of a bug related to an older version react-scripts not playing nice with the latest version of graphql (graphql/graphql-js#1248). Updating to the latest version of react-scripts (v2.1.1) fixed the bug. It also reduces the production build *considerably* (from over 1mb down to 48kb).
|
🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
This PR addresses the failing production build caused by an older version
react-scriptsnot playing nice with the latest version ofgraphqlUpdating to the latest version of react-scripts (v2.1.1) fixes the issue. It also happens to reduce the production build considerably (from over 1mb down to 48kb).
Specific updates (required)
react-scriptsfrom1.1.1to2.1.1and followed migration guide (https://github.com/facebook/create-react-app/blob/master/CHANGELOG.md#migrating-from-1x-to-203)prebuildandpostbuilduglify-es patch (not necessary with newest version of react-scripts)serve,apollo-cache-inmemory,apollo-client,apollo-link,babel-preset-react-appChecklist: