Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send requestID and streamID through to the runner for logging #3384

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mjh1
Copy link
Contributor

@mjh1 mjh1 commented Feb 7, 2025

Sending the requestID and streamID through from the gateway to orchestrator and from O to the runner to allow us to do contextual logging there and make debugging much easier.
Related runner PR: livepeer/ai-runner#413

@github-actions github-actions bot added go Pull requests that update Go code AI Issues and PR related to the AI-video branch. labels Feb 7, 2025
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 33 lines in your changes missing coverage. Please review.

Project coverage is 32.19459%. Comparing base (e7c416a) to head (1683875).

Files with missing lines Patch % Lines
server/ai_process.go 0.00000% 13 Missing ⚠️
server/ai_http.go 0.00000% 9 Missing ⚠️
ai/worker/worker.go 0.00000% 7 Missing ⚠️
core/ai_orchestrator.go 0.00000% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3384         +/-   ##
===================================================
- Coverage   32.21282%   32.19459%   -0.01823%     
===================================================
  Files            147         147                 
  Lines          40636       40659         +23     
===================================================
  Hits           13090       13090                 
- Misses         26775       26798         +23     
  Partials         771         771                 
Files with missing lines Coverage Δ
core/ai.go 58.51852% <ø> (ø)
server/rpc.go 66.66667% <ø> (ø)
core/ai_orchestrator.go 31.06796% <0.00000%> (ø)
ai/worker/worker.go 0.00000% <0.00000%> (ø)
server/ai_http.go 9.92248% <0.00000%> (-0.10887%) ⬇️
server/ai_process.go 0.59322% <0.00000%> (-0.00558%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7c416a...1683875. Read the comment docs.

Files with missing lines Coverage Δ
core/ai.go 58.51852% <ø> (ø)
server/rpc.go 66.66667% <ø> (ø)
core/ai_orchestrator.go 31.06796% <0.00000%> (ø)
ai/worker/worker.go 0.00000% <0.00000%> (ø)
server/ai_http.go 9.92248% <0.00000%> (-0.10887%) ⬇️
server/ai_process.go 0.59322% <0.00000%> (-0.00558%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AI Issues and PR related to the AI-video branch. go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant