Add a version metric #423
Merged
Add a version metric #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjpotter92
approved these changes
Feb 14, 2025
runner/app/main.py
Outdated
|
|
||
| config_logging() | ||
| logger = logging.getLogger(__name__) | ||
|
|
||
| VERSION = Counter('version', 'Runner version', ['app', 'version']) |
There was a problem hiding this comment.
the other version metrics are Gauge type. i don't know if it'd conflict with Counter or not. https://github.com/livepeer/studio/blob/2bb3b0ab4bd015e3e561266072580192af25cca3/packages/api/src/index.ts#L129-L142
when querying, we simply use the promql expression:
sum by (app, version) version{}
There was a problem hiding this comment.
hmm strange I saw go-livepeer and catalyst using counters, never mind i'll switch to gauge
| @@ -153,6 +153,7 @@ jobs: | |||
| file: docker/Dockerfile.live-app__PIPELINE__ | |||
| build-args: | | |||
| PIPELINE=${{ matrix.pipeline }} | |||
| GIT_SHA=$(git rev-parse HEAD) | |||
There was a problem hiding this comment.
need to use github expression here, as it doesn't run bash commands here:
GIT_SHA=${{ (github.ref_type == 'tag' && github.ref_name) || (github.event.pull_request.head.sha || github.sha) }}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a prometheus metric to record the version of the code running, so that we can track this in our dashboards.