Update protocol and add SendDataRequest nonce #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it seems like you haven't added any nanpa changeset files to this PR. if this pull request includes changes to code, make sure to add a changeset, by writing a file to refer to the manpage for more information. |
theomonnom
approved these changes
Jan 28, 2025
theomonnom
reviewed
Jan 28, 2025
| @@ -288,6 +289,8 @@ impl RoomClient { | |||
| data: Vec<u8>, | |||
| options: SendDataOptions, | |||
| ) -> ServiceResult<()> { | |||
| let mut rng = rand::rng(); | |||
| let nonce: Vec<u8> = (0..16).map(|_| rng.random::<u8>()).collect(); | |||
There was a problem hiding this comment.
nit, you could easily avoid heap allocation
let mut nonce = [0u8; 16];
There was a problem hiding this comment.
had this initially with rnd:fill(arr) but this required .to_vec() which copies everything into the vec. I guess it would still do heap allocation at the time of copying it into the vec?
There was a problem hiding this comment.
ah yeah, seems unnecessary then
rileyseaburg
pushed a commit
to Evolving-Software/livekit-rust-sdks
that referenced
this pull request
Feb 19, 2025
* Update protocol and add SendDataRequest nonce * changeset * typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.