Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(livekit): correctly calculate screenshare res #509

Closed
wants to merge 2 commits into from
Closed

fix(livekit): correctly calculate screenshare res #509

wants to merge 2 commits into from

Conversation

nbsp
Copy link
Member

@nbsp nbsp commented Dec 10, 2024 •
edited
Loading

removes 1080p15 from presets

@nbsp nbsp requested a review from theomonnom December 10, 2024 15:10
theomonnom
theomonnom reviewed Dec 10, 2024
View reviewed changes
Copy link
Member

@theomonnom theomonnom left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmh tho we will not be able to get the full resolution?
e.g preset is 1280x720 but our resolution is something like 1000x700. In this case the previous preset is going to lower that resolution?

@nbsp
Copy link
Member Author

nbsp commented Dec 10, 2024

resolution is computed separately; this just calculates the bitrate/framerate

@theomonnom
Copy link
Member

resolution is computed separately; this just calculates the bitrate/framerate

right tho you will need a bigger bitrate if the resolution is higher

@theomonnom
Copy link
Member

theomonnom commented Dec 10, 2024 •
edited
Loading

JS is doing the same: https://github.com/livekit/client-sdk-js/blob/0fe824b438cae99aa01a745c7165777a2ab4c2bb/src/room/participant/publishUtils.ts#L279

Tho our logic doesn't handle orientation and the condition ignore equality

@nbsp nbsp closed this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theomonnom theomonnom theomonnom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbsp @theomonnom