Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move libyuv/imgproc from theomonnom/mikado #508

Merged
merged 5 commits into from
Dec 10, 2024
Merged

move libyuv/imgproc from theomonnom/mikado #508

merged 5 commits into from
Dec 10, 2024

Conversation

theomonnom
Copy link
Member

@theomonnom theomonnom commented Dec 9, 2024 •
edited
Loading

was initially doing a side project with it, but interested in other stuff now. So kind of abandoned

@theomonnom theomonnom requested review from nbsp, davidzhao and a team December 9, 2024 11:16
@theomonnom theomonnom changed the title move libyuv from theomonnom/mikado move libyuv/imgproc from theomonnom/mikado Dec 9, 2024
nbsp
nbsp reviewed Dec 9, 2024
View reviewed changes
Copy link
Member

@nbsp nbsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe also set livekit-ffi dependencies to use relative imgproc? and imgproc to use relative yuv-sys? just for consistency with the rest of the repo

@theomonnom theomonnom merged commit c86758b into main Dec 10, 2024
5 checks passed
@theomonnom theomonnom deleted the theo/libyuv branch December 10, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbsp nbsp nbsp approved these changes

@davidzhao davidzhao Awaiting requested review from davidzhao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theomonnom @nbsp