Update to livekit-protocol v1.23.0 (Stubs only), fix tests #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcherry
changed the title
bcherry
commented
Oct 3, 2024
| itype: SOXR_INT16_I as u32, | ||
| otype: SOXR_INT16_I as u32, | ||
| itype: soxr_datatype_t_SOXR_INT16_I as u32, | ||
| otype: soxr_datatype_t_SOXR_INT16_I as u32, |
There was a problem hiding this comment.
fixes broken tests from main
bcherry
changed the title
bcherry
commented
Oct 3, 2024
| let amplitude = i16::MAX as f32; | ||
| writer.write_sample((sample * amplitude) as i16).expect("Failed to write sample"); | ||
| } | ||
| writer.finalize().expect("Failed to finalize test input WAV file"); |
There was a problem hiding this comment.
input.wav was missing in main and I got some inexplicable format issues with it in certain CI environments when I added it back (but it worked locally). So instead I'm creating the file on the fly for the test @theomonnom
theomonnom
reviewed
Oct 3, 2024
theomonnom
reviewed
Oct 3, 2024
theomonnom
approved these changes
Oct 3, 2024
Co-authored-by: Théo Monnom <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a lot of new stuff that landed in protocol recently and is breaking the rust build since it doesn't implement them:
To unblock people trying to build on these, I stubbed everything out in here so it compiles.
While I was at it, I fixed the broken tests in main. CI is still red because there are broken builds for a few platforms we aren't actively deploying to. I didn't address that.