Add chat API #436
Merged
Add chat API #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasIO
commented
Sep 25, 2024
livekit-ffi/src/proto.rs
Outdated
| include!("livekit.proto.rs"); | ||
|
|
||
| impl From<ChatMessage> for RoomChatMessage { |
There was a problem hiding this comment.
currently defining these conversions both in livekit-ffi and in livekit, which feels wrong, but couldn't make it work otherwise.
lukasIO
commented
Sep 25, 2024
lukasIO
commented
Sep 25, 2024
| @@ -40,3 +40,4 @@ futures-util = { version = "0.3", default-features = false, features = ["sink"] | |||
| thiserror = "1.0" | |||
| lazy_static = "1.4" | |||
| log = "0.4" | |||
| chrono = "0.4.38" | |||
There was a problem hiding this comment.
needed for timestamping chat messages
This was referenced Sep 25, 2024
theomonnom
approved these changes
Oct 9, 2024
| message EditChatMessageRequest { | ||
| uint64 local_participant_handle = 1; | ||
| string edit_text = 2; | ||
| ChatMessage original_message = 3; |
There was a problem hiding this comment.
Do we need the whole ChatMessage? Is it possible to just use the message_id?
There was a problem hiding this comment.
in an ideal world, yeah, the ID would be enough.
We don't have a central authority for chat messages though. So for an edited message we'd still want to keep the e.g. original timestamp of the message, so passing the whole message seemed like the best idea.
But would be happy about alternative suggestions
theomonnom
reviewed
Oct 9, 2024
theomonnom
reviewed
Oct 9, 2024
theomonnom
reviewed
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.