Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nanpa version management support #434

Merged
merged 2 commits into from
Sep 14, 2024
Merged

add nanpa version management support #434

merged 2 commits into from
Sep 14, 2024

Conversation

nbsp
Copy link
Member

@nbsp nbsp commented Sep 14, 2024

this adds support for versioning through nanpa, via the ilo GitHub bot.

usage guide

  1. on PRs, for each change, add a file to .nanpa/<unique-name>.kdl, that looks like this:

    patch type="added" package="livekit-ffi" "Add support for foo"
    

    alternatively you may add the file to ./livekit-ffi/.nanpa/, and then drop the package="livekit-ffi".

    types follow Keep a Changelog. you may add multiple lines per file.

  2. ilo will create an issue when there's changes in the main branch. use the checkboxes to pick which ones you want to bump. additionally, if you want to set a prerelease version on a package:

    ilo prerelease rust-sdks/livekit-ffi alpha

    or to un-prerelease a package:

    ilo prerelease rust-sdks/livekit-ffi

  3. close the issue, and the workflow should run, making a new commit and tagging it with all changed package versions.

note that when updating a package and its dependent, you need to either bump them seperately, or manually update the dependency's Cargo.toml, and then edit the dependent's manifest to include the new dep version.

repo settings that need to change

  • add ilo to the repository
  • set the NANPA_WORKFLOW environmental variable to publish.yml, for CI (not as a secret!)

this adds support for versioning through
[nanpa](https://github.com/nbsp/nanpa), via the
[ilo](https://github.com/nbsp/ilo) GitHub bot.

usage guide:
1. on PRs, for each change, add a file to `.nanpa/<unique-name>.kdl`,
   that looks like this:

    patch type="added" package="livekit-ffi" "Add support for foo"

   alternatively you may add the file to `./livekit-ffi/.nanpa/`,
   and then drop the `package="livekit-ffi"`.

   `type`s follow [Keep a Changelog](https://keepachangelog.org).
2. ilo will create an issue when there's changes in the main branch.
   use the checkboxes to pick which ones you want to bump.
   additionally, if you want to set a prerelease version on a package:

    ilo prerelease rust-sdks/livekit-ffi alpha

   or to un-prerelease a package:

    ilo prerelease rust-sdks/livekit-ffi
3. close the issue, and the workflow should run, making a new commit
   and tagging it with all changed package versions.

note that when updating a package and its dependent, you need to either
bump them seperately, or manually update the dependency's Cargo.toml,
and then edit the dependent's manifest to include the new dep version.

repo settings that need to change:

- add [ilo](https://github.com/apps/ilo-nanpa) to the repository
- set the `NANPA_WORKFLOW` environmental variable to `publish.yml`,
  for CI (not as a secret!)
@davidzhao
Copy link
Member

on PRs, for each change, add a file to .nanpa/.kdl, that looks like this:

It'd be great to have automation for this, otherwise it'd be easy for devs to forget.

Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg!

@nbsp
Copy link
Member Author

nbsp commented Sep 14, 2024

on PRs, for each change, add a file to .nanpa/.kdl, that looks like this:

It'd be great to have automation for this, otherwise it'd be easy for devs to forget.

i can always add this to the bot later (as a PR comment with a link), without any changes here

Copy link
Member

@theomonnom theomonnom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@nbsp nbsp merged commit e2ad85d into main Sep 14, 2024
1 check passed
@nbsp nbsp deleted the nbsp/add/nanpa branch September 14, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants