fix: better reconnection logic & safety #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theomonnom
changed the title
davidzhao
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RtcSessioneven when reconnecting. (Because it is not locked while reconnecting).This allow us to get the PC stats at whatever moment. This also change the fact that multiple operations can happens at the same time (send_data, create a new sender, remove a sender).
Some operations doesn't require the reconnection to be finished (e.g removing a sender)
Optionanymore (Always present but can't be in a unconnected state)The pattern is done in a manner where you can't do actions on a RtcSession without thinking about the reconnection logic