Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: room eos #198

Merged
merged 2 commits into from
Sep 23, 2023
Merged

feat: room eos #198

merged 2 commits into from
Sep 23, 2023

Conversation

theomonnom
Copy link
Member

No description provided.

@@ -210,6 +210,7 @@ message RoomEvent {
Reconnecting reconnecting = 19;
Reconnected reconnected = 20;
E2eeStateChanged e2ee_state_changed = 21;
RoomEOS eos = 22;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does it mean to be eos?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that the stream of events is finished. so we can stop listening

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy to hear better names

@theomonnom theomonnom merged commit c9bee67 into main Sep 23, 2023
14 checks passed
@theomonnom theomonnom deleted the theo/room-eos branch September 23, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants