Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ffi protocol improvements #164

Merged
merged 19 commits into from
Sep 3, 2023
Merged

ffi protocol improvements #164

merged 19 commits into from
Sep 3, 2023

Conversation

theomonnom
Copy link
Member

@theomonnom theomonnom commented Aug 21, 2023 •
edited
Loading

  • allow to capture audio data without copy
  • added play_from_disk example
  • separate the info and owned messages

breaking changes:

  • capture_frames is now async and automatically handle the clock
  • NativeAudioSource::new now requires the sample_rate and the num_channels

@theomonnom theomonnom requested a review from davidzhao August 25, 2023 19:09
davidzhao
davidzhao reviewed Aug 25, 2023
View reviewed changes
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!! just one comment re: sync.

examples/play_from_disk/src/main.rs Show resolved Hide resolved
livekit-webrtc/src/native/audio_source.rs Show resolved Hide resolved
davidzhao
davidzhao approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

examples/play_from_disk/src/main.rs Outdated Show resolved Hide resolved
livekit-webrtc/src/native/audio_source.rs Show resolved Hide resolved
@theomonnom theomonnom merged commit a934d50 into main Sep 3, 2023
14 checks passed
@theomonnom theomonnom deleted the theo/better-proto branch September 3, 2023 22:04
@theomonnom theomonnom mentioned this pull request Sep 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidzhao davidzhao davidzhao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theomonnom @davidzhao