Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace jsonwebtoken with jose #115

Merged
merged 9 commits into from
Dec 5, 2023
Merged

Replace jsonwebtoken with jose #115

merged 9 commits into from
Dec 5, 2023

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Nov 30, 2023

Builds on top of and
closes #59

@lukasIO lukasIO requested a review from davidzhao November 30, 2023 17:03
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! a few minor comments

src/AccessToken.ts Outdated Show resolved Hide resolved
src/AccessToken.ts Show resolved Hide resolved
src/AccessToken.ts Outdated Show resolved Hide resolved
src/WebhookReceiver.test.ts Outdated Show resolved Hide resolved
@lukasIO lukasIO changed the base branch from main to v2 December 5, 2023 16:23
@lukasIO lukasIO merged commit 1d854f6 into v2 Dec 5, 2023
2 checks passed
@lukasIO lukasIO deleted the pr/moham96/59 branch December 5, 2023 16:23
lukasIO added a commit that referenced this pull request Dec 6, 2023
* Replace jsonwebtoken with jose (#115)

* merge main

* Cleanup & Lint

* fix tests

* fix dependencies

* fix tests

* update protobuf lib

* move await

* address comments

* fix tests

---------

Co-authored-by: Mohammad Rasim <[email protected]>

* Use protobuf-es (#116)

* merge main

* Cleanup & Lint

* fix tests

* fix dependencies

* fix tests

* update protobuf lib

* use protobuf-es

* change package type to ESM and use vitest to support tests with ESM

* Use fully specified imports everywhere

* cleanup deps

* cleanup deps

---------

Co-authored-by: Mohammad Rasim <[email protected]>

* add changesets as publishing workflow

* add changeset command

* require node 18 as minimum

* fix eslint

* Add changesets

* Update happy-badgers-call.md

* remove legacy publishing workflow

* update protocol

* more changesets

---------

Co-authored-by: Mohammad Rasim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants