Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit additional typings for ts4.2 #491

Merged
merged 1 commit into from
Oct 27, 2022
Merged

Emit additional typings for ts4.2 #491

merged 1 commit into from
Oct 27, 2022

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Oct 26, 2022

uses downlevel-dts in the build step to emit type declarations compatible with ts4.2.
The reason for using 4.2 is that the ResizeObserver type isn't present in previous typescript versions, which results in a build error for versions <4.2.
Users that are stuck on typescript versions older than 4.2 can add "skipLibCheck": true to their tsconfig in order to make the library work (this is a recommended setting anyways and is part of the --init default tsconfig when creating a new project microsoft/TypeScript#37808).

@changeset-bot
Copy link

changeset-bot bot commented Oct 26, 2022

⚠️ No Changeset found

Latest commit: c612baa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lukasIO lukasIO requested a review from davidzhao October 26, 2022 11:36
@lukasIO lukasIO merged commit 2d5335b into main Oct 27, 2022
@lukasIO lukasIO deleted the lukas/downlevel-ts branch October 27, 2022 08:10
max-b pushed a commit to Invisv-Privacy/client-sdk-js that referenced this pull request Dec 5, 2022
max-b pushed a commit to Invisv-Privacy/client-sdk-js that referenced this pull request Dec 5, 2022
max-b pushed a commit to Invisv-Privacy/client-sdk-js that referenced this pull request Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants