Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow background views to be customized #35

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

yammada
Copy link

@yammada yammada commented Aug 25, 2022

Currently, SheetBackgroundView is a public UIView that can't be overridden. This factors out a SheetBackground protocol that can be implemented by library clients to create custom views. A new example "Custom Background View" was added to the example app as a demonstration.

Also, to cover a common use case, the alphaWhenDimmed value on the built in DimmingSheetBackgroundView is made public.

Copy link
Contributor

@mattczech mattczech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@yammada yammada merged commit d215001 into develop Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants