Replace WebView URL with one that supports JS API #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the title says, the WebView URI used doesn't work with the JavaScript API mentioned in the LiveChat docs. Specifically, it doesn't expose access to LC_API, the global object with LiveChat's functions. Using the new link enables that access, so apps can inject JS to update user's name, email, and other variables, without filling in a redundant form. Also I think it might come with performance improvements on older devices? Not 100% on that one but it feels faster in testing on my old Android.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says, the WebView URI used doesn't work with the JavaScript API mentioned in the LiveChat docs. Specifically, it doesn't expose access to LC_API, the global object with LiveChat's functions. Using the new link enables that access, so apps can inject JS to update user's name, email, and other variables, without filling in a redundant form.
Also I think it might come with performance improvements on older devices? Not 100% on that one but it feels faster in testing on my old Android.