Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modal] - Label heading fix for "full space content" Modal type + Avatar in the modal header #793

Merged
merged 4 commits into from
Sep 27, 2023
Merged

[Modal] - Label heading fix for "full space content" Modal type + Avatar in the modal header #793

merged 4 commits into from
Sep 27, 2023

Conversation

marcinsawicki
Copy link
Contributor

@marcinsawicki marcinsawicki commented Sep 21, 2023 •
edited
Loading

Description

Fix for labelHeading not visible in fullSpaceContent type.
Added possibility to put avatar in the ModalHeader component.

Storybook

https://feature/modal-full-space-fixes--613a8e945a5665003a05113b.chromatic.com/?path=/story/components-modal--modal-with-full-space-content

Checklist

Obligatory:

  • Self review (use this as your final check for proposed changes before requesting the review)
  • Add reviewers (livechat/design-system)
  • Add correct label
  • Assign pull request with the correct issue

@marcinsawicki marcinsawicki added bug Something isn't working feature New feature or request labels Sep 21, 2023
@marcinsawicki marcinsawicki self-assigned this Sep 21, 2023
@marcinsawicki marcinsawicki added this to the DS Beta milestone Sep 21, 2023
vladko-uxds
vladko-uxds approved these changes Sep 27, 2023
View reviewed changes
Copy link

@vladko-uxds vladko-uxds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@marcinsawicki marcinsawicki merged commit 5e013a0 into main Sep 27, 2023
@marcinsawicki marcinsawicki deleted the feature/modal-full-space-fixes branch September 27, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladko-uxds vladko-uxds vladko-uxds approved these changes

@VadymBezpalko VadymBezpalko VadymBezpalko approved these changes

Assignees

@marcinsawicki marcinsawicki

Labels
bug Something isn't working feature New feature or request
Projects
LiveChat Design System
Archived in project
Milestone
DS Beta
Development

Successfully merging this pull request may close these issues.
3 participants
@marcinsawicki @VadymBezpalko @vladko-uxds