Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#789 #790 [Avatar] Return color based on text, not initials. Apply background color only in case of image type #791

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

sgraczyk
Copy link

@sgraczyk sgraczyk commented Sep 19, 2023

Resolves: #789
Resolves: #790

Description

It generally fixes minor issues with Avatar background:

  • color applied based on text, not initials in order to prevent confusion of showing the same avatar in different sizes
  • color applied only when of type image in order to prevent small-ish rim displayed

Storybook

https://feature-789-and-790-avatar--613a8e945a5665003a05113b.chromatic.com/?path=/story/components-avatar--sizes

Checklist

Obligatory:

  • Self review (use this as your final check for proposed changes before requesting the review)
  • Add reviewers (livechat/design-system)
  • Add correct label
  • Assign pull request with the correct issue

@sgraczyk sgraczyk added the bug Something isn't working label Sep 19, 2023
@sgraczyk sgraczyk requested a review from a team September 19, 2023 11:20
@sgraczyk sgraczyk changed the title [Avatar] Return color based on text, not initials. Apply background color only in case of image type #789 #790 [Avatar] Return color based on text, not initials. Apply background color only in case of image type Sep 19, 2023
@sgraczyk sgraczyk merged commit 4e10036 into main Sep 19, 2023
@sgraczyk sgraczyk deleted the feature/789-and-790-avatar branch September 19, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants