Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#531 - Tooltip - Possibility to set display method for tooltip wrapper #739

Merged
merged 2 commits into from
Aug 28, 2023

Conversation

marcinsawicki
Copy link
Contributor

@marcinsawicki marcinsawicki commented Aug 21, 2023

Resolves: #531

Description

Tooltip wraps the element passed by triggerRenderer with div, which sometimes breaks the app's UI layout.
display: inherit on that div gives the possibility to control that.

Storybook

https://feature-531--613a8e945a5665003a05113b.chromatic.com/?path=/story/components-tooltip--default

Checklist

Obligatory:

  • Self review (use this as your final check for proposed changes before requesting the review)
  • Add reviewers (livechat/design-system)
  • Add correct label
  • Assign pull request with the correct issue

@marcinsawicki marcinsawicki added the bug Something isn't working label Aug 21, 2023
@marcinsawicki marcinsawicki added this to the DS Beta milestone Aug 21, 2023
@marcinsawicki marcinsawicki self-assigned this Aug 21, 2023
@marcinsawicki marcinsawicki merged commit c22ed7a into main Aug 28, 2023
@marcinsawicki marcinsawicki deleted the feature/531 branch August 28, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Tooltip component forces trigger element to be in a block-level element
2 participants