Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#697 - ActionMenu - Fix for the issue with opening/hiding the menu #707

Merged
merged 2 commits into from
Jul 31, 2023

Conversation

marcinsawicki
Copy link
Contributor

@marcinsawicki marcinsawicki commented Jul 28, 2023

Resolves: #697

Description

The issue was caused by removing the onClose handler from the Popover component used inside ActionMenu. That affected incorrectly to handling addEventListener/removeEventListener.

Storybook

https://feature-697--613a8e945a5665003a05113b.chromatic.com/?path=/story/components-actionmenu--keep-open-on-item-click

Checklist

Obligatory:

  • Self review (use this as your final check for proposed changes before requesting the review)
  • Add reviewers (livechat/design-system)
  • Add correct label
  • Assign pull request with the correct issue

@marcinsawicki marcinsawicki added the bug Something isn't working label Jul 28, 2023
@marcinsawicki marcinsawicki added this to the DS Beta milestone Jul 28, 2023
@marcinsawicki marcinsawicki self-assigned this Jul 28, 2023
@marcinsawicki marcinsawicki marked this pull request as ready for review July 28, 2023 09:44
@marcinsawicki marcinsawicki merged commit 1963d43 into main Jul 31, 2023
@marcinsawicki marcinsawicki deleted the feature/697 branch July 31, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[ActionMenu] - pressing key after focusing the button doesn't open the menu
3 participants