Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#696 - Avatar - Changes in avatar sizes #705

Merged
merged 3 commits into from
Aug 2, 2023
Merged

#696 - Avatar - Changes in avatar sizes #705

merged 3 commits into from
Aug 2, 2023

Conversation

marcinsawicki
Copy link
Contributor

@marcinsawicki marcinsawicki commented Jul 28, 2023

Resolves: #696

Description

Changed the sizes of the component according to the design documentation. Added xxxlarge size, values from large has been moved to the next size, and large has the new value.
This is the breaking change for every component usage with size large and above.

Storybook

https://feature-696--613a8e945a5665003a05113b.chromatic.com/?path=/story/components-avatar--sizes-with-status

Checklist

Obligatory:

  • Self review (use this as your final check for proposed changes before requesting the review)
  • Add reviewers (livechat/design-system)
  • Add correct label
  • Assign pull request with the correct issue

@marcinsawicki marcinsawicki added feature New feature or request design UI/UX oriented issue labels Jul 28, 2023
@marcinsawicki marcinsawicki added this to the DS Beta milestone Jul 28, 2023
@marcinsawicki marcinsawicki self-assigned this Jul 28, 2023
@marcinsawicki marcinsawicki marked this pull request as ready for review July 28, 2023 06:45
Copy link

@vladko-uxds vladko-uxds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@marcinsawicki marcinsawicki merged commit 4e78586 into main Aug 2, 2023
@marcinsawicki marcinsawicki deleted the feature/696 branch August 2, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design UI/UX oriented issue feature New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Avatar] - New size variant and naming(breaking changes)
3 participants