Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#548 - Button - New button variant, UI fixes #564

Merged
merged 1 commit into from
May 23, 2023
Merged

#548 - Button - New button variant, UI fixes #564

merged 1 commit into from
May 23, 2023

Conversation

marcinsawicki
Copy link
Contributor

@marcinsawicki marcinsawicki commented May 22, 2023 •
edited
Loading

Resolves: #548

Description

  • New dotted variant
  • correct large size height and width (in icon only variant)
  • fix with hover state on blocked button in plain variant

Storybook

https://feature-548--613a8e945a5665003a05113b.chromatic.com/

Checklist

Obligatory:

  • Self-review
  • Unit & integration tests
  • Storybook cases
  • Design review
  • Functional (QA) review

Optional:

  • Accessibility cases (keyboard control, correct HTML markup, etc.)

@marcinsawicki marcinsawicki added feature New feature or request documentation Documentation of any kind labels May 22, 2023
@marcinsawicki marcinsawicki added this to the v1.0.0 milestone May 22, 2023
@marcinsawicki marcinsawicki linked an issue May 22, 2023 that may be closed by this pull request
[Button] - New variant and fixes #548
Closed
@marcinsawicki marcinsawicki merged commit af3e0e3 into v1 May 23, 2023
@marcinsawicki marcinsawicki deleted the feature/548 branch May 23, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VadymBezpalko VadymBezpalko VadymBezpalko approved these changes

@MichalPaszowski MichalPaszowski Awaiting requested review from MichalPaszowski

Assignees
No one assigned
Labels
documentation Documentation of any kind feature New feature or request
Projects
LiveChat Design System
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Button] - New variant and fixes
2 participants
@marcinsawicki @VadymBezpalko