Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#479 #477 #395 - Picker - bug fixes #491

Merged
merged 4 commits into from
Feb 23, 2023
Merged

#479 #477 #395 - Picker - bug fixes #491

merged 4 commits into from
Feb 23, 2023

Conversation

marcinsawicki
Copy link
Contributor

@marcinsawicki marcinsawicki commented Feb 8, 2023

Resolves: #479 #477 #395

Description

Some bug fixes:

  • added ellipsis for long strings in Trigger Body (also added to list items)
  • fixed the issue in multi mode, where items could be removed even with a disabled state by just blocking the possibility to click the "x" icon
  • fixed the issue with selecting the items on a filtered list

Storybook

https://feature-picker-fixes--613a8e945a5665003a05113b.chromatic.com/

Checklist

Obligatory:

  • Self-review
  • Unit & integration tests
  • Storybook cases
  • Design review
  • Functional (QA) review

Optional:

  • Accessibility cases (keyboard control, correct HTML markup, etc.)

@marcinsawicki marcinsawicki added the WIP Work in progress label Feb 8, 2023
@marcinsawicki marcinsawicki added bug Something isn't working and removed WIP Work in progress labels Feb 8, 2023
@kstvsko kstvsko self-requested a review February 10, 2023 09:03
Copy link

@kstvsko kstvsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I have an option in multi-select with a long copy, it shows an ellipsis on the list, but when I select it, it glitches somehow, and it looks weird, it almost touches the "clear" button. But I am not 100% sure that we should fix it, because then we won't have a place where that kind of option will display fully. (I do not know if that's a problem)

image

@marcinsawicki marcinsawicki merged commit baf46cb into v1 Feb 23, 2023
@marcinsawicki marcinsawicki deleted the feature/picker-fixes branch February 23, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants