Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CARD] use default layout for nested components #454

Merged
merged 2 commits into from
Dec 9, 2022

Conversation

MichalPaszowski
Copy link
Contributor

Resolves: #421

Description

The previous version of the Card component had its children positioned vertically, not horizontally. This change makes sure that the current version does not introduce a regression.

Storybook

https://feature-421--613a8e945a5665003a05113b.chromatic.com/

Checklist

Obligatory:

  • Self-review
  • Unit & integration tests
  • Storybook cases
  • Design review
  • Functional (QA) review

Optional:

  • Accessibility cases (keyboard control, correct HTML markup, etc.)

@MichalPaszowski MichalPaszowski added the WIP Work in progress label Dec 5, 2022
@MichalPaszowski MichalPaszowski added this to the v1.0.0 milestone Dec 9, 2022
@MichalPaszowski MichalPaszowski removed the WIP Work in progress label Dec 9, 2022
@MichalPaszowski MichalPaszowski changed the title by default place children components in column [CARD] use default layout for nested components Dec 9, 2022
@MichalPaszowski MichalPaszowski merged commit a0a1328 into v1 Dec 9, 2022
@MichalPaszowski MichalPaszowski deleted the feature/421-children-positioning branch December 9, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants