#396 ButtonGroup rename SegmentedControl + component improvements #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstvsko
approved these changes
Sep 19, 2022
sgraczyk
reviewed
Sep 19, 2022
| @@ -0,0 +1,45 @@ | |||
| import * as React from 'react'; | |||
There was a problem hiding this comment.
Can you follow the story convention from eg. Avatar?
We're trying to avoid the renaming of the component using the Component suffix. This happens thanks to naming the first story Default.
sgraczyk
reviewed
Sep 19, 2022
packages/react-components/src/components/SegmentedControl/SegmentedControl.tsx
Outdated
Show resolved
Hide resolved
marcinsawicki
approved these changes
Sep 22, 2022
sgraczyk
reviewed
Sep 27, 2022
packages/react-components/src/components/SegmentedControl/SegmentedControl.tsx
Outdated
Show resolved
Hide resolved
jpyzio123
approved these changes
Sep 30, 2022
jpyzio123
approved these changes
Oct 21, 2022
sgraczyk
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #396
Description
Storybook
https://segmented-control--613a8e945a5665003a05113b.chromatic.com/?path=/story/components-segmented-control--controlled
Checklist
Obligatory:
Optional: