Remove disabled attribute from button #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lick if disabled is true
jpyzio123
approved these changes
Sep 7, 2022
sgraczyk
reviewed
Sep 7, 2022
packages/react-components/src/components/Button/Button.spec.tsx
Outdated
Show resolved
Hide resolved
sgraczyk
approved these changes
Sep 7, 2022
kstvsko
approved these changes
Sep 8, 2022
sgraczyk
changed the title
sgraczyk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses issue with
disabledattribute which creates more harm than it should be. Due to that, We run into problems especially with the tooltip component, which gets lost because his child has the disabled attribute.Even floating-ui recommends to handle
disabledelements in that way instead of passingdisabledattribute on the button.Here are good article about why we should avoid disabled buttons https://css-tricks.com/making-disabled-buttons-more-inclusive/
Storybook
https://feature-remove-button-disabled-attr--613a8e945a5665003a05113b.chromatic.com/
Checklist
Obligatory: