Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Picker): fix group headers' height and equalise padding #1453

Merged
merged 2 commits into from
Dec 10, 2024
Merged

fix(Picker): fix group headers' height and equalise padding #1453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
287b3d6
fix(Picker): fix group headers' height and equalize padding
ashbork Dec 10, 2024
6912434
Merge branch 'main' into feature/picker-responsive-group-headers
ashbork Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/react-components/src/components/Picker/components/PickerListItem.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,16 +90,15 @@ $base-class: 'picker-list';
margin-bottom: var(--spacing-05);
background-color: var(--picker-list-group-background);
cursor: auto;
padding: 12px 12px 4px;
height: 36px;
padding: 8px 12px;
color: var(--content-basic-secondary);

&::after {
position: absolute;
top: 0;
z-index: -1;
background: var(--picker-list-group-background);
height: 36px;
height: 100%;
content: '';
}

Expand Down
6 changes: 5 additions & 1 deletion packages/react-components/src/components/Picker/constants.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,11 @@ export const DEFAULT_EXTENDED_OPTIONS = [
{ key: 'one', name: 'Option one' },
{ key: 'two', name: 'Option two' },
{ key: 'three', name: 'Option three', disabled: true },
{ key: 'groupB', name: 'Group B title header', groupHeader: true },
{
key: 'groupB',
name: 'Group B title header, longer than one line',
groupHeader: true,
},
{ key: 'four', name: 'Option four' },
{ key: 'five', name: 'Option five' },
{ key: 'six', name: 'Option six', disabled: true },
Expand Down
Loading