Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Picker): fixing Picker filtering logic #1286

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

VadymBezpalko
Copy link
Contributor

@VadymBezpalko VadymBezpalko commented Aug 12, 2024

Resolves: #{issue-number}

Description

Fixing the Picker bug when changes in selected items array, with clearSearchAfterSelection prop enabled, caused filter input to be cleared.

Storybook

https://feature-picker-filter-fix--613a8e945a5665003a05113b.chromatic.com

Checklist

Obligatory:

  • Self review (use this as your final check for proposed changes before requesting the review)
  • Add correct label
  • Assign pull request with the correct issue

@VadymBezpalko VadymBezpalko added the bug Something isn't working label Aug 12, 2024
@VadymBezpalko VadymBezpalko self-assigned this Aug 12, 2024
@VadymBezpalko VadymBezpalko requested a review from ashbork August 12, 2024 10:30
@VadymBezpalko VadymBezpalko merged commit 8e0c4bd into main Aug 13, 2024
5 checks passed
@VadymBezpalko VadymBezpalko deleted the feature/picker-filter-fix branch August 13, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants