Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Badge] Differences in size between numbers #465

Closed
kstvsko opened this issue Dec 16, 2022 · 0 comments · Fixed by #496
Closed

[Badge] Differences in size between numbers #465

kstvsko opened this issue Dec 16, 2022 · 0 comments · Fixed by #496
Assignees
@marcinsawicki
Labels
bug Something isn't working

Comments

@kstvsko
Copy link

kstvsko commented Dec 16, 2022 •
edited
Loading

Describe the bug

Single and multiple digits provide different sizing of the badge.

Expected behavior

We should keep the same width for any kind of single or multiple digits for any scenario.

Screenshots

Kapture 2022-12-16 at 15 05 51
@kstvsko kstvsko added the bug Something isn't working label Dec 16, 2022
@kstvsko kstvsko added this to the v1.0.0 milestone Dec 16, 2022
@marcinsawicki marcinsawicki moved this to In Progress in LiveChat Design System Feb 15, 2023
@marcinsawicki marcinsawicki self-assigned this Feb 15, 2023
@marcinsawicki marcinsawicki mentioned this issue Feb 15, 2023
Merged
6 tasks
@marcinsawicki marcinsawicki moved this from In Progress to In Review in LiveChat Design System Feb 15, 2023
@marcinsawicki marcinsawicki linked a pull request Feb 15, 2023 that will close this issue
#465 - Badge - visual bug fix + story update #496
Merged
6 tasks
marcinsawicki added a commit that referenced this issue Feb 17, 2023
@marcinsawicki
#465 - Badge - visual bug fix + story update (#496)
aeef8c6 
visual bug fix + story update
@marcinsawicki marcinsawicki moved this from In Review to Done in LiveChat Design System Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcinsawicki marcinsawicki

Labels
bug Something isn't working
Projects
LiveChat Design System
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#465 - Badge - visual bug fix + story update livechat/design-system
2 participants
@marcinsawicki @kstvsko