Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Button] Change on focus property from box shadow to filter #440

Closed
rafalluksza opened this issue Oct 3, 2022 · 0 comments · Fixed by #439
Closed

[Button] Change on focus property from box shadow to filter #440

rafalluksza opened this issue Oct 3, 2022 · 0 comments · Fixed by #439
Assignees
@rafalluksza
Labels
bug Something isn't working

Comments

@rafalluksza
Copy link
Contributor

rafalluksza commented Oct 3, 2022 •
edited
Loading

When we use buttons and add the margin, the button's highlights are not in the right place. I changed from box-shadow to the filter: drop-shadow property.
@rafalluksza rafalluksza self-assigned this Oct 3, 2022
@rafalluksza rafalluksza added this to the v1.0.0 milestone Oct 3, 2022
@rafalluksza rafalluksza mentioned this issue Oct 3, 2022
Merged
6 tasks
@rafalluksza rafalluksza linked a pull request Oct 3, 2022 that will close this issue
#440 Change on focus property from box shadow to filter #439
Merged
6 tasks
MichalPaszowski pushed a commit that referenced this issue Oct 21, 2022
@rafalluksza
#440 Change on focus property from box shadow to filter (#439)
8eea927 
change on focus property from box shadow to filter
@marcinsawicki marcinsawicki moved this from In Review to Done in LiveChat Design System Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rafalluksza rafalluksza

Labels
bug Something isn't working
Projects
LiveChat Design System
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#440 Change on focus property from box shadow to filter livechat/design-system
2 participants
@marcinsawicki @rafalluksza