Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modal] Introduce more variants of Header and Footer #400

Closed
kstvsko opened this issue Sep 2, 2022 · 0 comments · Fixed by #498
Closed

[Modal] Introduce more variants of Header and Footer #400

kstvsko opened this issue Sep 2, 2022 · 0 comments · Fixed by #498
Assignees
@marcinsawicki
Labels
feature New feature or request

Comments

@kstvsko
Copy link

kstvsko commented Sep 2, 2022 •
edited
Loading

Description

We should add the variants of the Header and Footer based on the ones prepared in Figma. The variant with a stepper is to-be-discussed when the work on this issue will start.

Design

Footer variants
Header variants
@kstvsko kstvsko added the feature New feature or request label Sep 2, 2022
@kstvsko kstvsko added this to the v1.0.0 milestone Sep 2, 2022
@kstvsko kstvsko moved this to Backlog in LiveChat Design System Sep 2, 2022
@sgraczyk sgraczyk moved this from Backlog to Selected for Development in LiveChat Design System Sep 14, 2022
@marcinsawicki marcinsawicki moved this from Selected for Development to In Progress in LiveChat Design System Oct 14, 2022
@marcinsawicki marcinsawicki self-assigned this Oct 14, 2022
@marcinsawicki marcinsawicki moved this from In Progress to Selected for Development in LiveChat Design System Dec 2, 2022
@marcinsawicki marcinsawicki removed their assignment Dec 2, 2022
@marcinsawicki marcinsawicki moved this from Selected for Development to In Progress in LiveChat Design System Feb 15, 2023
@marcinsawicki marcinsawicki self-assigned this Feb 15, 2023
@marcinsawicki marcinsawicki mentioned this issue Feb 16, 2023
Merged
6 tasks
@marcinsawicki marcinsawicki moved this from In Progress to In Review in LiveChat Design System Feb 16, 2023
@marcinsawicki marcinsawicki linked a pull request Feb 16, 2023 that will close this issue
#400 - Modal - New header flow with labeled variant #498
Merged
6 tasks
marcinsawicki added a commit that referenced this issue Feb 27, 2023
@marcinsawicki
#400 - Modal - New header flow with labeled variant (#498)
bff8692 
* modal with new header flow + labelled variant + stories

* test fixes, a11y props for modal

* styles fixes

* Revert "styles fixes"

This reverts commit 152e937.

* style fixes

* removed ActionModal component + stories setup for Modal component
@marcinsawicki marcinsawicki moved this from In Review to Done in LiveChat Design System Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcinsawicki marcinsawicki

Labels
feature New feature or request
Projects
LiveChat Design System
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#400 - Modal - New header flow with labeled variant livechat/design-system
2 participants
@marcinsawicki @kstvsko