Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Switch] Add loading state, medium size and slightly refresh the UI #371

Closed
MrVorgoth opened this issue Jul 28, 2022 · 1 comment · Fixed by #372
Closed

[Switch] Add loading state, medium size and slightly refresh the UI #371

MrVorgoth opened this issue Jul 28, 2022 · 1 comment · Fixed by #372
Assignees
@MrVorgoth
Labels
design UI/UX oriented issue feature New feature or request

Comments

@MrVorgoth
Copy link
Contributor

MrVorgoth commented Jul 28, 2022 •
edited
Loading

Refactor of switch component:

  • adding loading state,
  • adding medium size,
  • visual refresh of component

Design: https://www.figma.com/file/2pFu80PXO5A2tfyrAGnx91/Product-Components?node-id=1881%3A156
@MrVorgoth MrVorgoth self-assigned this Jul 28, 2022
@MrVorgoth MrVorgoth added feature New feature or request design UI/UX oriented issue labels Jul 28, 2022
@MrVorgoth MrVorgoth moved this from Backlog to Selected for Development in LiveChat Design System Jul 28, 2022
@MrVorgoth MrVorgoth moved this from Selected for Development to In Progress in LiveChat Design System Jul 28, 2022
@MrVorgoth MrVorgoth mentioned this issue Aug 1, 2022
Merged
6 tasks
@MrVorgoth MrVorgoth changed the title [Switch] add loading state [Switch] refactor component and add loading state Aug 1, 2022
@sgraczyk sgraczyk added this to the v1.0.0 milestone Aug 3, 2022
@sgraczyk sgraczyk linked a pull request Aug 3, 2022 that will close this issue
#371 Add loading state, medium size and slightly refresh the UI #372
Merged
6 tasks
@sgraczyk sgraczyk changed the title [Switch] refactor component and add loading state [Switch] Add loading state, medium size and slightly refresh the UI Aug 3, 2022
@sgraczyk sgraczyk moved this from In Progress to In Review in LiveChat Design System Aug 8, 2022
sgraczyk pushed a commit that referenced this issue Aug 9, 2022
@MrVorgoth
#371 Add loading state, medium size and slightly refresh the UI (#372)
b55f00e 
* Added new icon states to the `Switch` component:
  * `loading` state
  * `on` state
  * `off` state

* The loading state is always on top when passed with other props (like disabled, which also adds an icon). The loading state also needs to have a disabled state, because we can't perform any action during loading.

* New `medium` size available in `Switch` component. I've also renamed the size:
  * `basic` -> `large`

* So to sum up - the 3 sizes are now: `compact` / `medium` / `large`
* Changed the SVG for `lock_black`
@sgraczyk sgraczyk moved this from In Review to Done in LiveChat Design System Aug 9, 2022
@sgraczyk
Copy link

Released in v1.0.0-alpha.19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrVorgoth MrVorgoth

Labels
design UI/UX oriented issue feature New feature or request
Projects
LiveChat Design System
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#371 Add loading state, medium size and slightly refresh the UI livechat/design-system
2 participants
@sgraczyk @MrVorgoth