Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Badge] Apply styles according to designs #341

Closed
sgraczyk opened this issue Jul 1, 2022 · 1 comment · Fixed by #356
Closed

[Badge] Apply styles according to designs #341

sgraczyk opened this issue Jul 1, 2022 · 1 comment · Fixed by #356
Assignees
@sgraczyk
Labels
feature New feature or request

Comments

@sgraczyk
Copy link

sgraczyk commented Jul 1, 2022

Description

Current implementation has styles that are misaligned with Figma designs.

Styles should be (to be confirmed within URL below):

  font-size: 12px;
  font-style: normal;
  font-weight: 600;
  line-height: 16px;
  letter-spacing: 0.2px;
  text-align: center;

Design

https://www.figma.com/file/2pFu80PXO5A2tfyrAGnx91/Product-Components?node-id=6904%3A34178
@sgraczyk sgraczyk added the feature New feature or request label Jul 1, 2022
@sgraczyk sgraczyk added this to the v1.0.0 milestone Jul 1, 2022
@sgraczyk sgraczyk moved this to Selected for Development in LiveChat Design System Jul 1, 2022
@sgraczyk sgraczyk self-assigned this Jul 25, 2022
@sgraczyk sgraczyk moved this from Selected for Development to In Progress in LiveChat Design System Jul 25, 2022
sgraczyk pushed a commit that referenced this issue Jul 25, 2022
#341 Reorganize Badge component to reflect Figma designs
cce8a2e
@sgraczyk sgraczyk linked a pull request Jul 25, 2022 that will close this issue
#341 Reorganize Badge component to reflect Figma designs #356
Merged
@sgraczyk sgraczyk mentioned this issue Jul 25, 2022
Merged
sgraczyk pushed a commit that referenced this issue Jul 26, 2022
#341 Reorganize Badge component to reflect Figma designs
d6d577f
sgraczyk pushed a commit that referenced this issue Jul 26, 2022
#341 Reorganize Badge component to reflect Figma designs (#356)
0eed2c7 
* Added `kind` prop instead of `secondary` boolean
* Added `size` to handle 3 cases
* Added `type` to automatically handle `alert` and `dot` variants
@sgraczyk sgraczyk moved this from In Progress to Done in LiveChat Design System Jul 26, 2022
@sgraczyk
Copy link
Author

Released in v1.0.0-alpha.17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgraczyk sgraczyk

Labels
feature New feature or request
Projects
LiveChat Design System
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#341 Reorganize Badge component to reflect Figma designs livechat/design-system
1 participant
@sgraczyk