Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Input][TagInput] Missing background design tokens #339

Closed
sgraczyk opened this issue Jul 1, 2022 · 1 comment · Fixed by #364
Closed

[Input][TagInput] Missing background design tokens #339

sgraczyk opened this issue Jul 1, 2022 · 1 comment · Fixed by #364
Assignees
@sgraczyk
Labels
bug Something isn't working

Comments

@sgraczyk
Copy link

sgraczyk commented Jul 1, 2022 •
edited
Loading

Describe the bug

Mentioned components do not apply different colors to the background while switching themes.
We need to add a token for background (--surface-basic)

Steps to reproduce

https://www.loom.com/share/252f553e2a9247da90890deff2e97b73

Expected behavior

--surface-basic token applied for TagInput and Input components on theme change

Screenshots

https://www.loom.com/share/252f553e2a9247da90890deff2e97b73

Environment

Additional context

n/a
@sgraczyk sgraczyk added the bug Something isn't working label Jul 1, 2022
@sgraczyk sgraczyk added this to the v1.0.0 milestone Jul 1, 2022
@sgraczyk sgraczyk moved this to Selected for Development in LiveChat Design System Jul 1, 2022
@sgraczyk sgraczyk changed the title [Input][Tag] Missing background design tokens [Input][TagInput] Missing background design tokens Jul 1, 2022
@sgraczyk sgraczyk moved this from Selected for Development to In Progress in LiveChat Design System Jul 25, 2022
@sgraczyk sgraczyk self-assigned this Jul 25, 2022
sgraczyk pushed a commit that referenced this issue Jul 27, 2022
#339 Apply missing tokens to Input and TagInput components
0b22563
@sgraczyk sgraczyk mentioned this issue Jul 27, 2022
Merged
6 tasks
@sgraczyk sgraczyk linked a pull request Jul 27, 2022 that will close this issue
#339 Apply missing tokens to Input and TagInput components #364
Merged
6 tasks
sgraczyk pushed a commit that referenced this issue Jul 27, 2022
#339 Apply missing tokens to Input and TagInput components (#364)
9a5b687 
* Added background and placeholder color tokens for `Input`
* Added background and disabled color tokens for `TagInput`
* Added `disabled` prop to `InputProps`
* Reorganized stories to cover sizes and states of Input components
@marcinsawicki marcinsawicki moved this from In Progress to Done in LiveChat Design System Aug 1, 2022
@sgraczyk
Copy link
Author

sgraczyk commented Aug 8, 2022

Released in v1.0.0-alpha.18

@sgraczyk sgraczyk closed this as completed Aug 8, 2022
marcinsawicki added a commit that referenced this issue Nov 25, 2022
@marcinsawicki
#342 Support type prop to set the type of input, adjusted styles to f…
48ecd8a 
…it with designs, added Icon functionality (#369)

* #339 Apply missing tokens to Input and TagInput components

* input styles update, added icon functionality, added kinds with password

* unit tests

* changes after review

* changes after review

* changes after review

* change the prop name

* changes after review

* export new Size type

* small change

* changes after tests, added possibility to set the place of the icon

Co-authored-by: Szymon Graczyk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgraczyk sgraczyk

Labels
bug Something isn't working
Projects
LiveChat Design System
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#339 Apply missing tokens to Input and TagInput components livechat/design-system
1 participant
@sgraczyk