Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Picker] Enable multi-select #338

Closed
marcinsawicki opened this issue Jul 1, 2022 · 0 comments · Fixed by #357
Closed

[Picker] Enable multi-select #338

marcinsawicki opened this issue Jul 1, 2022 · 0 comments · Fixed by #357
Assignees
@marcinsawicki
Labels
feature New feature or request

Comments

@marcinsawicki
Copy link
Contributor

Description

Picker component should be configurable to add the possibility to select multiple elements from the list.

Design

https://www.figma.com/file/2pFu80PXO5A2tfyrAGnx91/Product-Components?node-id=6122%3A61558
@marcinsawicki marcinsawicki added the feature New feature or request label Jul 1, 2022
@marcinsawicki marcinsawicki added this to the v1.0.0 milestone Jul 1, 2022
@marcinsawicki marcinsawicki self-assigned this Jul 1, 2022
@sgraczyk sgraczyk moved this to Backlog in LiveChat Design System Jul 1, 2022
@sgraczyk sgraczyk moved this from Backlog to Selected for Development in LiveChat Design System Jul 1, 2022
@sgraczyk sgraczyk changed the title Picker - add functionality enabling multiselect [Picker] Enable multi-select Jul 1, 2022
@marcinsawicki marcinsawicki moved this from Selected for Development to In Progress in LiveChat Design System Jul 8, 2022
@marcinsawicki marcinsawicki mentioned this issue Jul 26, 2022
Merged
@marcinsawicki marcinsawicki linked a pull request Jul 26, 2022 that will close this issue
#338 Changes in Picker component related to enabling the multiselect option #357
Merged
@marcinsawicki marcinsawicki moved this from In Progress to In Review in LiveChat Design System Sep 27, 2022
marcinsawicki added a commit that referenced this issue Nov 10, 2022
@marcinsawicki
#338 Changes in Picker component related to enabling the multiselect …
75cca89 
…option (#357)

* temp commit to move changes

* multiselect mode with tags, select all option, unit tests, css changes

* fix for selecting logic and tests

* revert package-lock

* changes after review: moved trigger body as component, interfaces changes, removed internal state of selected items

* update tests

* update tests

* changes after review, bugs fixes, code refactor

* changes

* more tests for Picker components

* fixes after design review

* changes after review

* bug fix related to selecting items in multipicker mode

* changes after testing

* fixed issue with select all option

* change logic related to the select all option

Co-authored-by: Marcin Sawicki <[email protected]>
@marcinsawicki marcinsawicki moved this from In Review to Done in LiveChat Design System Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcinsawicki marcinsawicki

Labels
feature New feature or request
Projects
LiveChat Design System
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#338 Changes in Picker component related to enabling the multiselect option livechat/design-system
1 participant
@marcinsawicki