Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the logout button #2906

Merged
merged 10 commits into from
Jan 8, 2025
Merged

Implement the logout button #2906

merged 10 commits into from
Jan 8, 2025

Conversation

aleDsz
Copy link
Member

@aleDsz aleDsz commented Jan 3, 2025

image

image

@aleDsz aleDsz self-assigned this Jan 3, 2025
Copy link

github-actions bot commented Jan 3, 2025

Uffizzi Preview deployment-59515 was deleted.

lib/livebook/zta.ex Outdated Show resolved Hide resolved
@josevalim
Copy link
Contributor

I have a nitpicky suggestion: I don't like the logout and shutdown button being so closer to each other. What do you think about moving the shutdown button to just below the "Settings" one?

Screenshot 2025-01-06 at 21 16 13

lib/livebook/zta.ex Outdated Show resolved Hide resolved
lib/livebook/zta.ex Outdated Show resolved Hide resolved
@aleDsz
Copy link
Member Author

aleDsz commented Jan 7, 2025

I have a nitpicky suggestion: I don't like the logout and shutdown button being so closer to each other. What do you think about moving the shutdown button to just below the "Settings" one?

Screenshot 2025-01-06 at 21 16 13

Done

image

@hugobarauna
Copy link
Member

I have a nitpicky suggestion: I don't like the logout and shutdown button being so closer to each other. What do you think about moving the shutdown button to just below the "Settings" one?
Screenshot 2025-01-06 at 21 16 13

Done

image

I thought the idea was to move up the "shutdown" and keep logout down:

What do you think about moving the shutdown button to just below the "Settings" one?

@aleDsz aleDsz requested a review from jonatanklosko January 7, 2025 20:40
lib/livebook/zta.ex Outdated Show resolved Hide resolved
Copy link
Contributor

@josevalim josevalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added two tiny comments which you can apply and ship it!!!!

@aleDsz aleDsz merged commit 601e93a into main Jan 8, 2025
7 checks passed
@aleDsz aleDsz deleted the ale-logout-user branch January 23, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants