Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add smart cell definition for KinoFLAME with k8s backend #2762

Merged
merged 7 commits into from
Sep 5, 2024

Conversation

mruoss
Copy link
Contributor

@mruoss mruoss commented Aug 28, 2024

Once livebook-dev/kino_flame#3 is merged, let's add a definition for Kubernetes backend with the required packages. I guess there is no way to set the "backend" attribute to "k8s", right?

Copy link

github-actions bot commented Aug 28, 2024

Uffizzi Preview deployment-55631 was deleted.

@jonatanklosko
Copy link
Member

I guess there is no way to set the "backend" attribute to "k8s", right?

The smart cell itself should guess the default "backend" based on the environment. We could do check which backend module is installed, but since Fly is built-in, that's not reliable. I think the best option is to check env vars, same ones we check for the warning. I see you already do that on the PR, so it should be enough, no?

@mruoss mruoss force-pushed the kino-flame-definitions branch from 2a9df01 to b6a6f55 Compare August 29, 2024 19:53
@mruoss
Copy link
Contributor Author

mruoss commented Aug 29, 2024

Have removed yaml_elixir from the deps.

@mruoss mruoss changed the title WIP: add smart cell definition for KinoFLAME with k8s backend Add smart cell definition for KinoFLAME with k8s backend Sep 5, 2024
@jonatanklosko jonatanklosko merged commit c060efb into livebook-dev:main Sep 5, 2024
7 checks passed
jonatanklosko added a commit that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants