Defer distribution boot in releases #2648
Conversation
|
Uffizzi Preview |
| Livebook.Config.cookie!("LIVEBOOK_COOKIE") || | ||
| Livebook.Config.cookie!("RELEASE_COOKIE") || | ||
| Livebook.Utils.random_cookie() | ||
| Livebook.Config.cookie!("LIVEBOOK_COOKIE") || Livebook.Utils.random_cookie() |
There was a problem hiding this comment.
@josevalim we are no longer respecting RELEASE_NODE, because the Elixir release script defaults its value to release name, which we don't want to use. I think we should ignore RELEASE_COOKIE also for consistency. I think it makes sense to expect the configuration to happen via LIVEBOOK_* env vars.
| cookie_path="${RELEASE_ROOT}/releases/COOKIE" | ||
| if [ ! -f $cookie_path ] && [ -z "$RELEASE_COOKIE" ]; then | ||
| RELEASE_COOKIE=$(cat /dev/urandom | env LC_ALL=C tr -dc 'a-zA-Z0-9' | fold -w 32 | head -n 1) | ||
| echo "$RELEASE_COOKIE" > "$cookie_path" || export RELEASE_COOKIE |
There was a problem hiding this comment.
FTR we used to attempt to write the random cookie to a file and respect RELEASE_COOKIE, such that the cookie was the same on subsequent boots. This was necessary because in the past Livebook Desktop was calling bin/release rpc and so it had to use the same cookie. We no longer do that though, so I simplified the code to no longer write the file.
Follow up to #2646 that fixes releases. We need to specify the default node name, but whether we want
127.0.0.1or::1depends on-proto_dist, which can be passed in multiple ways and is hard to know in the env files. I realised that instead of usingRELEASE_DISTRIBUTION=nameas typically, we can setRELEASE_DISTRIBUTION=noneand let the distribution be started on application boot, as we do formix phx.serverand Escript. This way we have a single code path for setting up distribution and also less logic in the release env files.