Document request proxy and shift boundaries #2617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uffizzi Preview |
|
I'm gonna merge to open another PR, if anyone has design concerns I can do a follow up :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runtime.fetch_proxy_handler_spec/1now returns{:ok, {module, function, args}}and the plug just doesapply(module, function, args ++ [conn]). This minimises the surface between the Livebook server and the runtime. This effectively means thatLivebook.Proxy.Serveris a part of runtime implementation (but the part operating on the Livebook side :)). This also means that all the specific messaging betweenProxy.ServerandProxy.Adapteris "internal" from design point of view.