feat: add drag-and-drop for xlsx-format #2577
Conversation
|
|
Dragging an xlsx-file onto a livebook should load the code-snipplet. In order for the DataTable to load the code assumes that the first row contains column-labels.
|
Please find a xlsx-file attached - which can be used to test the functionality. Kind regards, Fabian |
|
Uffizzi Preview |
|
💚 💙 💜 💛 ❤️ |
|
Oh my - i believe "mix format" needs a run? :) Thanks for the support - please let me know if you want me to do this. Kind regards, |
|
No worries, fixed on main :) |
| tabs = | ||
| for sheet <- XlsxReader.sheet_names(package) do | ||
| # Assume the first row contains column names | ||
| {:ok, [header | rows]} = XlsxReader.sheet(package, sheet) |
There was a problem hiding this comment.
I've just tested with some real sheets, and got a problem here in a scenario that I think it's very common:
the file has several sheets with values, but one of the sheets is empty and it fails matching in this line.
how about doing something like below?
tabs =
for sheet <- XlsxReader.sheet_names(package),
{:ok, rows} = XlsxReader.sheet(package, sheet),
length(rows) > 1 do
[header | rows] = rows
maps =
Enum.map(rows, fn row ->
header
|> Enum.zip(row)
|> Map.new(fn
{k, :expect_chars} -> {k, nil}
kv -> kv
end)
end)
{sheet, Kino.DataTable.new(maps)}
endThere was a problem hiding this comment.
also added this :expect_chars handling, because in many cases when the value is empty, that's what I get instead from the library, not sure if it's a behaviour we should change in xlsx_reader cc @xavier
There was a problem hiding this comment.
@rodrigues what if we add two options to xlsx_reader? One to skip empty sheets and another to nillify expect_chars?
There was a problem hiding this comment.
that sounds good to me, sheet_names/2 could handle skip_empty: true.
about :expect_chars, it sounds to me like maybe it should be nil by default, but I don't know the reasoning for returning it today.
There was a problem hiding this comment.
@rodrigues would you open up issues/send PRs to xlsx_reader, please? :)
There was a problem hiding this comment.
yep I'll find some time to work on these two 👌
Dragging an xlsx-file onto a livebook should load the code-snipplet.
In order for the DataTable to load the code assumes that a sheet called "Sheet 1" exists and that the first row contains column-labels.
There are still some corner-cases which have to do with loading data from Excel in the general sense.
The library https://github.com/xavier/xlsx_reader from https://github.com/xavier was used in the addition.
Hopefully some users will find the addition useful.