Don't reconnect when WebSocket returns server error #2264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uffizzi Preview |
josevalim
reviewed
Oct 9, 2023
josevalim
reviewed
Oct 10, 2023
josevalim
reviewed
Oct 10, 2023
josevalim
approved these changes
Oct 10, 2023
aleDsz
changed the title
aleDsz
changed the title
|
After a discussion with @aleDsz, we concluded we need to have a notification system for delivering messages that are not caused by user actions. |
jonatanklosko
pushed a commit
that referenced
this pull request
Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1675 we added this sleeping time, but since then we didn't notice that until last week.
If the org credentials are invalid, the
Liveboook.Teams.Connectiongen state will send a server error message toLivebook.Hubs.TeamClient, which should send the message only time using theLivebook.Hubs.Broadcastsmodule.Before this change, it was spamming like 5 times the message and it would keep showing in the frontend. But now it only shows one time and closes the gen server before it sends again.